caishunfeng commented on code in PR #13013:
URL:
https://github.com/apache/dolphinscheduler/pull/13013#discussion_r1035449340
##########
dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/NetUtilsTest.java:
##########
@@ -115,4 +115,40 @@ public void testIsValidAddress() {
Assertions.assertFalse(NetUtils.isValidV4Address(address));
}
+ @Test
+ public void
giveIpAddress_thenCheckIsValidIPv4Address_thenCheck_expectNormal() {
+ Assertions.assertFalse(NetUtils.isValidIPv4Address(""));
+
+ String ipAddress = "127.0.0.1";
Review Comment:
> sure, but the format of the `host` is too broad, i want to just add a
fuzzy check. WDYT.
What kind of fuzzy check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
