darkz1984 commented on code in PR #12826:
URL: 
https://github.com/apache/dolphinscheduler/pull/12826#discussion_r1038089138


##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql:
##########
@@ -796,6 +797,7 @@ CREATE TABLE t_ds_task_instance (
 ) ;
 
 create index idx_task_instance_code_version on t_ds_task_instance (task_code, 
task_definition_version);
+create index idx_task_instance_process_instance_flag on t_ds_task_instance 
(process_instance_id, flag);

Review Comment:
   And add an index for a big t_ds_task_instance with much rows online when 
dolphinscheduler is running in PostgreSQL is very easy and just cost few 
milliseconds. 
   But this action in MySQL is very danger, It may lead table lock and long 
time cost,  My be an production accident.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to