EricGao888 commented on PR #12930: URL: https://github.com/apache/dolphinscheduler/pull/12930#issuecomment-1336173060
> > I can see your point here. But I'm wondering why u choose to remove the previous var instead of preventing users from defining multiple vars of the same `prop`? > > https://github.com/apache/dolphinscheduler/blob/ffc9fb280aa4609efc219550899a599ece2a5ada/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/AbstractParameters.java#L202-L205 > > Hi, @EricGao888, this change provides two ways to update upstream parameters: > > * Use `setValue` in script without additional output parameter definition. **(Original way, with higher priority)** > * Define the output parameter with same name, directly set value in the definition. **(New way, bug will be fixed in this pr)** Hi @Radeity, if what u are doing in this PR aims to provides users with the ability to update the parameter passed by upstream tasks, this looks good to me. What I'm concerned about is whether there is a possibility the user does not intend to update the parameter but mistakenly create a parameter with a duplicate key and this change will override the parameter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
