fuchanghai commented on PR #13057:
URL:
https://github.com/apache/dolphinscheduler/pull/13057#issuecomment-1336416083
useA and useB open same process definition，then useA delete a node and
save。use b run the node that had been deleted。in method of buildflowdag will
throw npe。above cause master print a lot of log，The hard drive ran
out of space。finally you start any process instance will failed
---Original---
From: "Aaron ***@***.***>
Date: Sun, Dec 4, 2022 20:43 PM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/dolphinscheduler] [improve-#13053] in method of
```execProcessInstance``` check ```startNodeList``` (PR #13057)
@Radeity commented on this pull request.
I wonder whether this check is needed? If userA delete a node, a new version
of process is created. Meanwhile, userB want to execute the deleted node, if he
runs the old version, there's no errors. So i think the right logic should be:
if user do not update process instance, he should run the old version, instead,
run the new version.
Also, this check brings additional overhead. WDYT?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
