jieguangzhou commented on code in PR #13077:
URL:
https://github.com/apache/dolphinscheduler/pull/13077#discussion_r1039087164
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java:
##########
@@ -422,7 +422,6 @@ private void addProcessStopEvent(ProcessInstance
processInstance) {
private void addTaskRetryEvent(TaskInstance taskInstance) {
TaskStateEvent stateEvent = TaskStateEvent.builder()
.processInstanceId(taskInstance.getProcessInstanceId())
- .taskInstanceId(taskInstance.getId())
Review Comment:
We only use the task instance Id to print logs in the
TaskRetryStateEventHandler.
If an existing task instance id is set when the task is retried, no new task
instance will be created
This is pr solved by setting the id: #13074, and I closed it because I think
the new one is simpler to fix the bug.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
