github-code-scanning[bot] commented on code in PR #13106:
URL:
https://github.com/apache/dolphinscheduler/pull/13106#discussion_r1040391044
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -1089,12 +1104,10 @@
}
taskMainInfoIPage.setRecords(Lists.newArrayList(taskMainInfoMap.values()));
}
- PageInfo<TaskMainInfo> pageInfo = new PageInfo<>(pageNo, pageSize);
- pageInfo.setTotal((int) taskMainInfoIPage.getTotal());
- pageInfo.setTotalList(taskMainInfoIPage.getRecords());
- result.setData(pageInfo);
- putMsg(result, Status.SUCCESS);
- return result;
+ }
+
+ private void fillWorkflowInfo(long projectCode, IPage<TaskMainInfo>
taskMainInfoIPage) {
Review Comment:
## Useless parameter
The parameter 'taskMainInfoIPage' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/2384)
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -1089,12 +1104,10 @@
}
taskMainInfoIPage.setRecords(Lists.newArrayList(taskMainInfoMap.values()));
}
- PageInfo<TaskMainInfo> pageInfo = new PageInfo<>(pageNo, pageSize);
- pageInfo.setTotal((int) taskMainInfoIPage.getTotal());
- pageInfo.setTotalList(taskMainInfoIPage.getRecords());
- result.setData(pageInfo);
- putMsg(result, Status.SUCCESS);
- return result;
+ }
+
+ private void fillWorkflowInfo(long projectCode, IPage<TaskMainInfo>
taskMainInfoIPage) {
Review Comment:
## Useless parameter
The parameter 'projectCode' is never used.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/2383)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
