Radeity commented on PR #13118:
URL: 
https://github.com/apache/dolphinscheduler/pull/13118#issuecomment-1342017737

   > @Radeity You are correct, the order of elements in the List remain the 
same. But the order of elements in the json objects inside the list do not 
remain the same. As the funtion objectMapper.writeValueAsString(object) is used 
to convert the object into string without mentioning a SerializationFeature, 
the order of the key,value pairs is not guaranteed. So the test can fail or 
pass on the same version of the code. This flakiness detected by NonDex as 
shown in the error log can lead to test failures even though the json is the 
same(ignoring the order). So my solution is just to compare the jsons without 
considering the order. This ensures that the testcase passes.
   
   Get it, thanks for your explanation!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to