github-actions[bot] commented on issue #13145:
URL: 
https://github.com/apache/dolphinscheduler/issues/13145#issuecomment-1343887139

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   dolphin scheduler version: 3.0.2
   zookeeper: 3.7.1
   jdk: 1.8.0
   database: mysql 5.7.32
   
   After upgrade ds from 1.3.6 to 3.0.2, when click process definitions on 
webui, it says process definitions pagination query failed, as the screenshot 
below
   
   After upgrading from 1.3.6 to 3.0.2, the process definition cannot be loaded 
normally. After clicking the workflow definition column, the page prompts "Page 
query workflow definition list error"
   
   
![image](https://user-images.githubusercontent.com/92249031/206630658-2289cfb4-433c-489b-a561-ca73a74707c0.png)
   
   When click the task name on task instance page, it says no task definition 
found, as the screenshot below
   
![image](https://user-images.githubusercontent.com/92249031/206633520-573368d8-a09f-44f1-9deb-2f3e19f108ce.png)
   
   
![image](https://user-images.githubusercontent.com/92249031/206633336-494e7b90-27e6-4945-9a43-db5022a11770.png)
   
   
   Meanwhile, api-log has the following error message
   The log error of the api service is as follows
   
   ``` log
   [ERROR] 2022-12-09 13:25:47.578 +0800 
org.apache.dolphinscheduler.api.exceptions.ApiExceptionHandler:[53] - Paged 
query workflow definition list error
   java.lang.NullPointerException: null
   at 
org.apache.dolphinscheduler.api.service.impl.ProcessDefinitionServiceImpl.queryProcessDefinitionListPaging(ProcessDefinitionServiceImpl.java:462)
   at 
org.apache.dolphinscheduler.api.service.impl.ProcessDefinitionServiceImpl$$FastClassBySpringCGLIB$$e8e34ed9.invoke(<generated>)
   at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
   at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:689)
   at 
org.apache.dolphinscheduler.api.service.impl.ProcessDefinitionServiceImpl$$EnhancerBySpringCGLIB$$6ad4eb9e.queryProcessDefinitionListPaging(<generated>)
   at 
org.apache.dolphinscheduler.api.controller.ProcessDefinitionController.queryProcessDefinitionListPaging(ProcessDefinitionController.java:483)
   at 
org.apache.dolphinscheduler.api.controller.ProcessDefinitionController$$FastClassBySpringCGLIB$$dc9bf5db.invoke(<generated>)
   at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
   at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:783)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
   at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753)
   at 
org.springframework.aop.aspectj.MethodInvocationProceedingJoinPoint.proceed(MethodInvocationProceedingJoinPoint.java:89)
   at 
org.apache.dolphinscheduler.api.aspect.AccessLogAspect.doAround(AccessLogAspect.java:101)
   at sun.reflect.GeneratedMethodAccessor174.invoke(Unknown Source)
   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:498)
   at 
org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:634)
   at 
org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:624)
   at 
org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:72)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:175)
   at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753)
   at 
org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
   at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
   at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:753)
   at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:698)
   at 
org.apache.dolphinscheduler.api.controller.ProcessDefinitionController$$EnhancerBySpringCGLIB$$14b2ad04.queryProcessDefinitionListPaging(<generated>)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:498)
   at 
org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
   at 
org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150)
   at 
org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)
   at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)
   at 
org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808)
   at 
org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87)
   at 
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1067)
   at 
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:963)
   at 
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
   at 
org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:898)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:497)
   at 
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:584)
   at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
   at 
org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1631)
   at 
com.github.xiaoymin.swaggerbootstrapui.filter.SecurityBasicAuthFilter.doFilter(SecurityBasicAuthFilter.java:84)
   at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
   at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
   at 
com.github.xiaoymin.swaggerbootstrapui.filter.ProductionSecurityFilter.doFilter(ProductionSecurityFilter.java:53)
   at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
   at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
   at 
org.springframework.web.filter.CorsFilter.doFilterInternal(CorsFilter.java:91)
   at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
   at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
   at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
   at 
org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100)
   at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
   at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
   at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
   at 
org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93)
   at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
   at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
   at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
   at 
org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:96)
   at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
   at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
   at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
   at 
org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201)
   at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119)
   at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
   at 
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
   at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:548)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
   at 
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
   at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
   at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
   at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1434)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
   at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:501)
   at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
   at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1349)
   at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
   at 
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:763)
   at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
   at org.eclipse.jetty.server.Server.handle(Server.java:516)
   at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:400)
   at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:645)
   at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:392)
   at 
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
   at 
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
   at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
   at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
   at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
   at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
   at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
   at 
org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
   at 
org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
   at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
   at 
org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
   at java.lang.Thread.run(Thread.java:750)
   ```
   
   The locations field of table t_ds_process_definition looks like below, and 
table t_ds_task_definition has no records
   
   The json in the locations field of the process definition table in the 
metadata database is still the structure of the old version, and the task 
definition table is empty and has no data
   ``` log
   {
       "tasks-5054": {
           "name": "ods_product_prev clear data",
           "targetarr": "",
           "nodenumber": "3",
           "x": 102,
           "y": 84
       },
       "tasks-22742": {
           "name": "ods_product_prev data pull",
           "targetarr": "tasks-5054",
           "nodenumber": "2",
           "x": 455,
           "y": 18
       },
       "tasks-24658": {
           "name": "ods_product_delta deletes the partition 7 days ago",
           "targetarr": "tasks-22742",
           "nodenumber": "1",
           "x": 423,
           "y": 156
       },
       "tasks-24718": {
           "name": "ods_product_delta partition table write incremental data",
           "targetarr": "tasks-24658,tasks-2-2ujl6",
           "nodenumber": "0",
           "x": 441,
           "y": 283
       },
       "tasks-2-2ujl6": {
           "name": "ods_pro-2ujl6",
           "targetarr": "tasks-22742",
           "nodenumber": "1",
           "x": 861,
           "y": 113
       },
       "tasks-4278": {
           "name": "ods_product_prev",
           "targetarr": "tasks-5054",
           "nodenumber": "0",
           "x": 208,
           "y": 376
       }
   ```
   
   
   
   Error message when run the tools/bin/upgrade-schema.sh
   
   Upgrade script error record json split error, method 
splitProcessDefinitionJson
   ``` log
   2022-12-07 21:05:23.576 ERROR 6963 --- [ main] 
o.a.d.tools.datasource.dao.UpgradeDao : json split error
   
   java.lang.NullPointerException: null
   at 
org.apache.dolphinscheduler.tools.datasource.dao.UpgradeDao.splitProcessDefinitionJson(UpgradeDao.java:494)
 [dolphinscheduler-tools-3.0.2.jar:3.0.2]
   at 
org.apache.dolphinscheduler.tools.datasource.dao.UpgradeDao.processDefinitionJsonSplit(UpgradeDao.java:437)
 [dolphinscheduler-tools-3.0.2.jar:3.0.2]
   at 
org.apache.dolphinscheduler.tools.datasource.dao.UpgradeDao.upgradeDolphinSchedulerTo200(UpgradeDao.java:171)
 [dolphinscheduler-tools-3.0.2.jar:3.0.2]
   at 
org.apache.dolphinscheduler.tools.datasource.DolphinSchedulerManager.upgradeDolphinScheduler(DolphinSchedulerManager.java:115)
 [dolphinscheduler-tools-3.0.2.jar:3.0.2]
   at 
org.apache.dolphinscheduler.tools.datasource.UpgradeDolphinScheduler$UpgradeRunner.run(UpgradeDolphinScheduler.java:48)
 [dolphinscheduler-tools-3.0.2.jar:3.0.2]
   at 
org.springframework.boot.SpringApplication.callRunner(SpringApplication.java:791)
 [spring-boot-2.5.6.jar:2.5.6]
   at 
org.springframework.boot.SpringApplication.callRunners(SpringApplication.java:775)
 [spring-boot-2.5.6.jar:2.5.6]
   at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:345) 
[spring-boot-2.5.6.jar:2.5.6]
   at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1343) 
[spring-boot-2.5.6.jar:2.5.6]
   at 
org.springframework.boot.SpringApplication.run(SpringApplication.java:1332) 
[spring-boot-2.5.6.jar:2.5.6]
   at 
org.apache.dolphinscheduler.tools.datasource.UpgradeDolphinScheduler.main(UpgradeDolphinScheduler.java:31)
 [dolphinscheduler-tools-3.0.2.jar:3.0.2]
   ```
   upgrade steps
   upgrade steps
   
   1. upgrade zookeeper from 3.4.5 to 3.7.1
   2. backup database of dolphinscheduler 1.3.6
   3. upgrade schema against the backup database (by running the 
upgrade_schema.sh) to 3.0.2
   4. configure all the files of 3.0.2 (dolphinscheduler_env.sh, 
install_env.sh, application.yaml, commons.properties)
   5. run install.sh
   6. run start-all.sh
   
   ### What you expected to happen
   
   Process definition pagination query working properly
   
   ### How to reproduce
   
   Upgrade from 1.3.6 to 3.0.2
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   3.0.x
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to