liugddx commented on issue #13210: URL: https://github.com/apache/dolphinscheduler/issues/13210#issuecomment-1360878425
> this is just a IDEA warnning, but i do think that construct will better than`@Autowired`, In terms of readability, `@Autowired` is better, and if we will inject many beans, o huge constuct may not be a good idea. WDYT Thanks for the reply, if you write the constructor directly, it will make the code poorly readable, but we use lombok to solve this problem. In addition, this is not just a warning from IDEA, you can see https://blog.marcnuri.com/field-injection-is-not-recommended for details. Of course, the purpose of my mentioning this PR is to lower my contribution threshold, and I am happy to contribute my strength to dolphinscheduler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
