Radeity commented on PR #13273: URL: https://github.com/apache/dolphinscheduler/pull/13273#issuecomment-1364644272
> The only reason the similar join in this file is because the condition of the query is `project id` instead of `project code`.(countInstanceStateV2) You need to clear all process_definition before deleting the project. Therefore, I think it is unnecessary to guarantee the existence of project by joining t_ds_project table Actually, there are many similar join in other files, like `countTaskInstanceStateByProjectCodesAndStatesBySubmitTime` in `TaskInstanceMapper.xml`, if they are really unnecessary, maybe you can remove them together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
