zhongjiajie commented on code in PR #13301:
URL:
https://github.com/apache/dolphinscheduler/pull/13301#discussion_r1059212907
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/SchedulerService.java:
##########
@@ -128,12 +128,11 @@ Schedule getSchedule(User loginUser,
* @param projectCode project code
* @param id scheduler id
* @param scheduleStatus schedule status
- * @return publish result code
*/
- Map<String, Object> setScheduleState(User loginUser,
- long projectCode,
- Integer id,
- ReleaseState scheduleStatus);
+ void setScheduleState(User loginUser,
Review Comment:
In the previous, we just return the error message inside the hashmap, we
should avoid wrapper error but directly throw the exceptions in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]