EricGao888 commented on code in PR #13312:
URL:
https://github.com/apache/dolphinscheduler/pull/13312#discussion_r1060248727
##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -4,8 +4,8 @@
We here use MySQL as an example to illustrate how to configure an external
database:
-> NOTE: If you use MySQL, you need to manually download [mysql-connector-java
driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
-> which is `api-server/libs` and `alert-server/libs` and `master-server/libs`
and `worker-server/libs`.
+> NOTE: If you use MySQL, you need to manually download [mysql-connector-java
driver][mysql] (8.0.16) and unzip then move it to the libs directory of
DolphinScheduler
+> which is `api-server/libs` and `alert-server/libs` and `master-server/libs`
and `worker-server/libs` and `tools/libs`.
Review Comment:
```suggestion
> which are `api-server/libs`, `alert-server/libs`, `master-server/libs` and
`tools/libs`. Because DolphinScheduler worker no more accesses database, there
is no need to copy it to `worker-server/libs` unless your task plugins need to
access mysql database.
```
##########
docs/docs/en/guide/howto/datasource-setting.md:
##########
@@ -4,8 +4,8 @@
We here use MySQL as an example to illustrate how to configure an external
database:
-> NOTE: If you use MySQL, you need to manually download [mysql-connector-java
driver][mysql] (8.0.16) and move it to the libs directory of DolphinScheduler
-> which is `api-server/libs` and `alert-server/libs` and `master-server/libs`
and `worker-server/libs`.
+> NOTE: If you use MySQL, you need to manually download [mysql-connector-java
driver][mysql] (8.0.16) and unzip then move it to the libs directory of
DolphinScheduler
Review Comment:
```suggestion
> NOTE: If you use MySQL, you need to manually download
[mysql-connector-java driver][mysql] (8.0.16), unzip it and then copy it to the
lib directories of DolphinScheduler components,
```
##########
docs/docs/zh/guide/howto/datasource-setting.md:
##########
@@ -23,7 +23,7 @@ export SPRING_DATASOURCE_PASSWORD={password}
DolphinScheduler 元数据存储在关系型数据库中，目前支持 PostgreSQL 和 MySQL。下面分别介绍如何使用 MySQL 和
PostgresQL 初始化数据库。
-> 如果使用 MySQL 需要手动下载 [mysql-connector-java 驱动][mysql] (8.0.16) 并移动到
DolphinScheduler 的每个模块的 libs 目录下，其中包括 `api-server/libs` 和 `alert-server/libs` 和
`master-server/libs` 和 `worker-server/libs`。
+> 如果使用 MySQL，需要手动下载 [mysql-connector-java 驱动][mysql] (8.0.16) 并解压后移动到
DolphinScheduler 的每个模块的 libs 目录下，其中包括
`api-server/libs`、`alert-server/libs`、`master-server/libs`、`worker-server/libs`、`tools/libs`。
Review Comment:
```suggestion
> 如果使用 MySQL，需要手动下载 [mysql-connector-java 驱动][mysql] (8.0.16) 并解压后移动到
DolphinScheduler 的每个模块的 libs 目录下，其中包括
`api-server/libs`、`alert-server/libs`、`master-server/libs`、`tools/libs`。因为
DolphinScheduler 的 worker
不再需要访问数据库，您不再需要将驱动放到`worker-server/libs`目录下，除非您的任务插件需要访问 MySQL 数据库。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
