[GitHub] [dolphinscheduler] imizao commented on a diff in pull request #13354: [Refactor][UI]Add a back button when viewing an error file

Sun, 08 Jan 2023 18:35:34 -0800 


imizao commented on code in PR #13354:
URL: 
https://github.com/apache/dolphinscheduler/pull/13354#discussion_r1064250643


##########
dolphinscheduler-ui/src/views/resource/file/edit/index.tsx:
##########
@@ -109,7 +109,21 @@ export default defineComponent({
           </div>
         ) : (
           <NSpace justify='center'>
-            <NSpin show={true} />
+            <NSpace vertical>

Review Comment:
   Yes, you are right!
   
   But, I think adding the NSpace tag is to make the UI look more beautiful!
   
   Commenting out the span tagļ¼š
   
   
![reply1](https://user-images.githubusercontent.com/20340304/211232714-d3489c7b-43c7-46a3-80bc-b04b0d00703c.jpg)
   
   After
   
![reply2](https://user-images.githubusercontent.com/20340304/211232746-7b541a71-7234-4d17-85cb-0e195215cdfb.jpg)
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to