ruanwenjun commented on code in PR #13360:
URL:
https://github.com/apache/dolphinscheduler/pull/13360#discussion_r1064498794
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-dataquality/src/main/java/org/apache/dolphinscheduler/plugin/task/dq/DataQualityTask.java:
##########
@@ -71,6 +71,16 @@ public class DataQualityTask extends AbstractYarnTask {
*/
private static final String SPARK_COMMAND =
"${SPARK_HOME}/bin/spark-submit";
+ /**
+ * --class CLASS_NAME
+ */
+ public static final String MAIN_CLASS = "--class";
+
+ /**
+ * DataQuality mainClass name
+ */
+ private static final String DATA_QUALITY_MAIN_CLASS_NAME =
"org.apache.dolphinscheduler.data.quality.DataQualityApplication";
Review Comment:
We don't need to add this after add manifest in pom.xml
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-dataquality/src/main/java/org/apache/dolphinscheduler/plugin/task/dq/DataQualityTask.java:
##########
@@ -71,6 +71,16 @@ public class DataQualityTask extends AbstractYarnTask {
*/
private static final String SPARK_COMMAND =
"${SPARK_HOME}/bin/spark-submit";
+ /**
+ * --class CLASS_NAME
+ */
+ public static final String MAIN_CLASS = "--class";
+
+ /**
+ * DataQuality mainClass name
+ */
+ private static final String DATA_QUALITY_MAIN_CLASS_NAME =
"org.apache.dolphinscheduler.data.quality.DataQualityApplication";
Review Comment:
We may don't need to add this after add manifest in pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
