kezhenxu94 commented on code in PR #11598:
URL:
https://github.com/apache/dolphinscheduler/pull/11598#discussion_r1065635363
##########
dolphinscheduler-dist/release-docs/licenses/LISCENSE-perfmark-api.txt:
##########
@@ -0,0 +1,201 @@
+ Apache License
Review Comment:
You didn't add any new dependencies, this file is unexpected, please remove
or confirm where this dependency is brought
##########
dolphinscheduler-bom/pom.xml:
##########
@@ -258,6 +258,26 @@
<scope>import</scope>
</dependency>
+ <!-- Etcd -->
+ <dependency>
+ <groupId>io.etcd</groupId>
+ <artifactId>jetcd-core</artifactId>
+ <version>${jetcd.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>io.etcd</groupId>
+ <artifactId>jetcd-test</artifactId>
+ <version>${jetcd.test.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>io.grpc</groupId>
+ <artifactId>grpc-bom</artifactId>
+ <version>${io.grpc.version}</version>
+ <scope>import</scope>
+ <type>pom</type>
+ </dependency>
+
Review Comment:
Remove these lines
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -365,13 +379,31 @@ private String executeUpdate(Connection connection,
List<SqlBinds> statementsBin
int result = 0;
for (SqlBinds sqlBind : statementsBinds) {
try (PreparedStatement statement =
prepareStatementAndBind(connection, sqlBind)) {
+
+ sqlLogListener(statement);
+
result = statement.executeUpdate();
logger.info("{} statement execute update result: {}, for sql:
{}", handlerType, result, sqlBind.getSql());
}
}
return String.valueOf(result);
}
+ /**
+ * sql log listener
+ *
+ * @param statement statement
+ * @throws SQLException sqlException
+ */
+ private void sqlLogListener(PreparedStatement statement) throws
SQLException {
+ if (DbType.HIVE.name().equals(sqlParameters.getType())) {
+ logger.info("The current sql task type is HIVE, will start a demon
thread to resolve the appIds");
Review Comment:
```suggestion
logger.info("The current sql task type is HIVE, will start a
daemon thread to resolve the appIds");
```
##########
dolphinscheduler-api/pom.xml:
##########
@@ -195,6 +195,11 @@
<artifactId>hbase-noop-htrace</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.springframework.cloud</groupId>
+
<artifactId>spring-cloud-starter-kubernetes-fabric8-config</artifactId>
+ </dependency>
+
Review Comment:
Remove this, perhaps you do it wrong when resolving conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
