[dolphinscheduler] branch dev updated: fix when the task details are not modified, the predecessor node cannot be modified (#13422)

[caishunfeng]

This is an automated email from the ASF dual-hosted git repository.

caishunfeng pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 3b54de0c90 fix when the task details are not modified, the predecessor 
node cannot be modified (#13422)
3b54de0c90 is described below

commit 3b54de0c90083aaf0857362e7c237fb85ba3976c
Author: jackfanwan <61672564+jackfan...@users.noreply.github.com>
AuthorDate: Wed Jan 18 20:08:28 2023 +0800

    fix when the task details are not modified, the predecessor node cannot be 
modified (#13422)
    
    * fix when the task details are not modified, the predecessor node cannot 
be modified
    
    * deleted useless code
    
    Co-authored-by: fanwanlong <fanwanl...@kezaihui.com>
---
 .../api/service/impl/TaskDefinitionServiceImpl.java                | 7 -------
 1 file changed, 7 deletions(-)

diff --git 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
index e79507c6b5..ab71e9445c 100644
--- 
a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
+++ 
b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
@@ -820,9 +820,6 @@ public class TaskDefinitionServiceImpl extends 
BaseServiceImpl implements TaskDe
         Map<String, Object> result = new HashMap<>();
         TaskDefinitionLog taskDefinitionToUpdate =
                 updateTask(loginUser, projectCode, taskCode, 
taskDefinitionJsonObj, result);
-        if (result.get(Constants.STATUS) != Status.SUCCESS && 
taskDefinitionToUpdate == null) {
-            return result;
-        }
         List<ProcessTaskRelation> upstreamTaskRelations =
                 processTaskRelationMapper.queryUpstreamByCode(projectCode, 
taskCode);
         Set<Long> upstreamCodeSet =
@@ -835,10 +832,6 @@ public class TaskDefinitionServiceImpl extends 
BaseServiceImpl implements TaskDe
         if (CollectionUtils.isEqualCollection(upstreamCodeSet, 
upstreamTaskCodes) && taskDefinitionToUpdate == null) {
             putMsg(result, Status.SUCCESS);
             return result;
-        } else {
-            if (taskDefinitionToUpdate == null) {
-                taskDefinitionToUpdate = 
JSONUtils.parseObject(taskDefinitionJsonObj, TaskDefinitionLog.class);
-            }
         }
         Map<Long, TaskDefinition> queryUpStreamTaskCodeMap;
         if (CollectionUtils.isNotEmpty(upstreamTaskCodes)) {