caishunfeng commented on code in PR #13448:
URL:
https://github.com/apache/dolphinscheduler/pull/13448#discussion_r1089872219
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/ExecutorDispatcher.java:
##########
@@ -86,13 +86,13 @@ public Boolean dispatch(final ExecutionContext context)
throws ExecuteException
if (StringUtils.isEmpty(host.getAddress())) {
logger.warn("fail to execute : {} due to no suitable worker,
current task needs worker group {} to execute",
context.getCommand(), context.getWorkerGroup());
- return false;
+ throw new ExecuteException("no suitable worker");
Review Comment:
```suggestion
throw new WorkerGroupNotFoundException("no suitable worker");
```
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/executor/NettyExecutorManager.java:
##########
@@ -101,11 +102,9 @@ public Boolean execute(ExecutionContext context) throws
ExecuteException {
Command command = context.getCommand();
// execute task host
Host host = context.getHost();
- boolean success = false;
- while (!success) {
+ while (true) {
Review Comment:
It seems never return if no exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
