This is an automated email from the ASF dual-hosted git repository.

jinyleechina pushed a commit to branch 2.0.8-prepare
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/2.0.8-prepare by this push:
     new 3130810bdd [Improvement-13413] [Master] Empty dependency operation 
causes Master null pointer exception (#13457)
3130810bdd is described below

commit 3130810bddc23a17e910e99429f50fd457600c61
Author: Molin Wang <[email protected]>
AuthorDate: Mon Jan 30 16:02:34 2023 +0800

    [Improvement-13413] [Master] Empty dependency operation causes Master null 
pointer exception (#13457)
---
 .../dolphinscheduler/common/task/dependent/DependentParameters.java    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/dependent/DependentParameters.java
 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/dependent/DependentParameters.java
index 5f2e0e1853..72cf790074 100644
--- 
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/dependent/DependentParameters.java
+++ 
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/dependent/DependentParameters.java
@@ -16,6 +16,7 @@
  */
 package org.apache.dolphinscheduler.common.task.dependent;
 
+import org.apache.commons.collections.CollectionUtils;
 import org.apache.dolphinscheduler.common.enums.DependentRelation;
 import org.apache.dolphinscheduler.common.model.DependentTaskModel;
 import org.apache.dolphinscheduler.common.process.ResourceInfo;
@@ -33,7 +34,7 @@ public class DependentParameters extends AbstractParameters {
 
     @Override
     public boolean checkParameters() {
-        return true;
+        return CollectionUtils.isNotEmpty(dependTaskList) && relation != null;
     }
 
     @Override

Reply via email to