seedscoder commented on code in PR #13509: URL: https://github.com/apache/dolphinscheduler/pull/13509#discussion_r1096835620
########## lombok.config: ########## @@ -16,3 +16,5 @@ # lombok.addLombokGeneratedAnnotation = true + +lombok.log.fieldname=LOGGER Review Comment: Lombok will generate a `static final ` field, so I changed the field name to uppercase. Is this inappropriate? Need to change to lowercase？ ```java @Generated private static final Logger LOGGER = LoggerFactory.getLogger(Xxx.class); ``` > Why we don't keep the default field name `log`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
