ruanwenjun commented on code in PR #13206:
URL:
https://github.com/apache/dolphinscheduler/pull/13206#discussion_r1102519316
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/runner/TaskCallbackImpl.java:
##########
@@ -59,4 +59,18 @@ public void updateRemoteApplicationInfo(int taskInstanceId,
ApplicationInfo appl
taskExecutionContext.setAppIds(applicationInfo.getAppIds());
workerMessageSender.sendMessageWithRetry(taskExecutionContext,
masterAddress, CommandType.TASK_EXECUTE_RUNNING);
}
+
+ @Override
+ public void updateTaskInstanceInfo(int taskInstanceId) {
+ TaskExecutionContext taskExecutionContext =
+
TaskExecutionContextCacheManager.getByTaskInstanceId(taskInstanceId);
+ if (taskExecutionContext == null) {
+ log.error("task execution context is empty, taskInstanceId: {}",
taskInstanceId);
+ return;
+ }
+
+ log.info("send remote taskExecutionContext info {}",
taskExecutionContext);
+ workerMessageSender.sendMessageWithRetry(taskExecutionContext,
masterAddress, CommandType.TASK_EXECUTE_RUNNING);
Review Comment:
It's better to use a new message type here, otherwise this message will loos
if the running message have not been sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
