rickchengx commented on PR #13536:
URL:
https://github.com/apache/dolphinscheduler/pull/13536#issuecomment-1439341614
> > I just find another error, which confuse me. May i ask why we have `res`
in `ResourceInfo`, can we directly use `resourceName` (`fullName`) to generate
the submit command? @caishunfeng @SbloodyS
> > ```java
> > return mainJar.getId() == null
> > ? mainJar.getRes()
> > // when update resource maybe has error
> > : mainJar.getResourceName().replaceFirst("/", "");
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > The above codes return wrong `resName`, for example, `resourceName` is
`hdfs://xxx:9000/dolphinscheduler/resources/spark-examples_2.12-3.1.2.jar`,
after replacing, it will return
`hdfs:/xxx:9000/dolphinscheduler/resources/spark-examples_2.12-3.1.2.jar`.
>
> I've checked and found that `res` is useless, remove relative read and
write, PTAL @caishunfeng @SbloodyS @EricGao888, thx!
Hi, @Radeity , May I ask is `res` in `ResourceInfo` is completely useless？If
yes, is it possible to consider removing it, since it seems that `res` and
`resourceName` are confused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
