[GitHub] [dolphinscheduler] rickchengx commented on a diff in pull request #12698: [Improvement-12697][UT] Improve the ProjectServiceTest

Wed, 22 Feb 2023 18:02:53 -0800 


rickchengx commented on code in PR #12698:
URL: 
https://github.com/apache/dolphinscheduler/pull/12698#discussion_r1115175566


##########
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ProjectServiceTest.java:
##########
@@ -159,31 +156,10 @@ public void testCheckProjectAndAuth() {
         result = projectService.checkProjectAndAuth(loginUser, project, 
projectCode, PROJECT);
         logger.info(result.toString());
         Assertions.assertEquals(Status.SUCCESS, result.get(Constants.STATUS));
-

Review Comment:
   Hi, @EricGao888 , thanks for your comment. I removed these two cases because 
these two cases (PROJECT_NOT_EXIST and USER_NO_OPERATION_PROJECT_PERM) have 
been tested before, as shown in the figure below:
   
   <img width="977" alt="截屏2023-02-23 09 57 18" 
src="https://user-images.githubusercontent.com/38122586/220805709-8c01cdd0-686c-48d9-8ef7-2bf38e62b60e.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to