QuantumXiecao opened a new pull request, #13627: URL: https://github.com/apache/dolphinscheduler/pull/13627
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.--> ## Purpose of the pull request [fix-13625] Modify systemd-run from MemoryMax to MemoryLimit for more generality. ## Related PR: #13625 ## Brief change log My PR modifies systemd-run from MemoryMax to MemoryLimit for more generality. I have tested the following os: Centos/Fedora/Red Hat/SUSE Linux/Debian/Ubuntu and find the following conclusion: MemoryLimit is more universal than MemoryMax. Some os of above support both and some only support MemoryLimit like the following picture depicts:  (Apparently this issue encounter the same problem). But there is one os bug for centos as illustrated by the below pic:  But the os manual tells us(man systemd.resource-control):  Apparently this is os bug(for other linux always work right for MemoryLimit=infinity). I donot think we should ajust our codes for os bug. That is why I still keep the MemoryLimit=infinity part. But if some users who use that version os(centos 7.*), they would encounter command execution error for MemoryLimit=infinity. I advise they upgrade to centos 8.* which has solved this os bug. ## Verify this pull request <!--*(Please pick either of the following options)*--> This pull request is code cleanup without any test coverage. *(or)* This pull request is already covered by existing tests, such as *(please describe tests)*. (or) This change added tests and can be verified as follows: <!--*(example:)* - *Added dolphinscheduler-dao tests for end-to-end.* - *Added CronUtilsTest to verify the change.* - *Manually verified the change by testing locally.* --> (or) If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
