kezhenxu94 commented on code in PR #13663:
URL:
https://github.com/apache/dolphinscheduler/pull/13663#discussion_r1123990105
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/am/KubernetesApplicationManager.java:
##########
@@ -190,7 +190,7 @@ public String
collectPodLog(KubernetesApplicationManagerContext kubernetesApplic
return logs;
}
} catch (Exception e) {
- log.error("Collect pod log failed:", e.getMessage());
+ log.error("Collect pod log failed: {}", e.getMessage());
Review Comment:
Ideally this should be 👇 so the exception stack can be printed
```suggestion
log.error("Collect pod log failed", e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
