github-code-scanning[bot] commented on code in PR #13798:
URL:
https://github.com/apache/dolphinscheduler/pull/13798#discussion_r1149126587
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/message/TaskExecuteRunningMessageSender.java:
##########
@@ -44,11 +44,10 @@
workerRpcClient.send(Host.of(message.getMessageReceiverAddress()),
message.convert2Command());
}
- public TaskExecuteRunningCommand buildMessage(@NonNull
TaskExecutionContext taskExecutionContext,
- @NonNull String
messageReceiverAddress) {
+ public TaskExecuteRunningCommand buildMessage(@NonNull
TaskExecutionContext taskExecutionContext) {
Review Comment:
## Missing Override annotation
This method overrides
[MessageSender<TaskExecuteRunningCommand>.buildMessage](1); it is advisable to
add an Override annotation.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/2734)
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/message/TaskExecuteResultMessageSender.java:
##########
@@ -42,11 +42,10 @@
workerRpcClient.send(Host.of(message.getMessageReceiverAddress()),
message.convert2Command());
}
- public TaskExecuteResultCommand buildMessage(TaskExecutionContext
taskExecutionContext,
- String
messageReceiverAddress) {
+ public TaskExecuteResultCommand buildMessage(TaskExecutionContext
taskExecutionContext) {
Review Comment:
## Missing Override annotation
This method overrides
[MessageSender<TaskExecuteResultCommand>.buildMessage](1); it is advisable to
add an Override annotation.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/2733)
##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/message/TaskRejectMessageSender.java:
##########
@@ -42,9 +42,9 @@
workerRpcClient.send(Host.of(message.getMessageReceiverAddress()),
message.convert2Command());
}
- public TaskRejectCommand buildMessage(TaskExecutionContext
taskExecutionContext, String masterAddress) {
+ public TaskRejectCommand buildMessage(TaskExecutionContext
taskExecutionContext) {
Review Comment:
## Missing Override annotation
This method overrides [MessageSender<TaskRejectCommand>.buildMessage](1); it
is advisable to add an Override annotation.
[Show more
details](https://github.com/apache/dolphinscheduler/security/code-scanning/2735)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
