LiJie20190102 commented on code in PR #13683:
URL:
https://github.com/apache/dolphinscheduler/pull/13683#discussion_r1155685463
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -1810,6 +1808,10 @@ private ResourceInfo updateResourceInfo(ResourceInfo
res) {
resourceInfo = new ResourceInfo();
// get resource from database, only one resource should be returned
Resource resource = getResourceById(resourceId);
+ if (Objects.isNull(resource)) {
+ logger.error("resource not found, resourceId: {}", resourceId);
+ return null;
Review Comment:
> can we directly throw the exception here?
I don't think this is feasible because if an exception is thrown here, there
will be a failed queue that will retry the task indefinitely, causing the error
log to refresh the screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
