ruanwenjun commented on PR #13896:
URL:
https://github.com/apache/dolphinscheduler/pull/13896#issuecomment-1501812167
> > > Since the instance's memory/cpu might different, use percentage is
more suitable, otherwise we need to set different config.
> >
> >
> > If physical memory of different worker vary significantly, such as
workerA has 8G memory and workerB has 64G, it's better to set different config,
WDYT?
> > Anyway, we can still use different percentage to represent it if you
think percentage is more intuitive :D
>
> Actually I think both make sense to me. May I ask whether it is possible
to keep both of them and give users an option to configure whether by physical
memory or by percentage?
This is possible, we can provide different strategy, e.g percentage,
absolute value. This will need to change the whole config.
```yml
avoid-overload:
strategy: Percentage
max-memory-usage: 70%
max-cpu-usage: 80%
# strategy: AbsoluteValue
# max-memory-usage: 6G
# max-cpu-usage: 6C
```
If this is needed, I will improve this in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
