EricGao888 commented on code in PR #13861:
URL:
https://github.com/apache/dolphinscheduler/pull/13861#discussion_r1164939554
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -668,6 +668,10 @@ export default {
zeppelin_parameters_tips: '请输入zeppelin dynamic form参数',
zeppelin_rest_endpoint: 'zeppelinRestEndpoint',
zeppelin_rest_endpoint_tips: '请输入zeppelin server的rest endpoint',
+ zeppelin_user_name: 'zeppelinUserName',
Review Comment:
```suggestion
zeppelin_username: 'zeppelinUsername',
```
##########
dolphinscheduler-ui/src/locales/en_US/project.ts:
##########
@@ -680,6 +680,10 @@ export default {
'Directory for cloned zeppelin note in production mode',
zeppelin_production_note_directory_tips:
'Please enter the production note directory to enable production mode',
+ zeppelin_user_name: 'zeppelinUserName',
+ zeppelin_user_name_tips: 'Please enter the zeppelin server user name',
+ zeppelin_pass_word: 'zeppelinPassWord',
Review Comment:
```suggestion
zeppelin_password: 'zeppelinPassword',
```
##########
dolphinscheduler-ui/src/locales/en_US/project.ts:
##########
@@ -680,6 +680,10 @@ export default {
'Directory for cloned zeppelin note in production mode',
zeppelin_production_note_directory_tips:
'Please enter the production note directory to enable production mode',
+ zeppelin_user_name: 'zeppelinUserName',
Review Comment:
```suggestion
zeppelin_username: 'zeppelinUsername',
```
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinParameters.java:
##########
@@ -1,57 +1,59 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.dolphinscheduler.plugin.task.zeppelin;
-
-import org.apache.dolphinscheduler.plugin.task.api.model.ResourceInfo;
-import
org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters;
-
-import org.apache.commons.lang3.StringUtils;
-
-import java.util.Collections;
-import java.util.List;
-
-import lombok.Getter;
-import lombok.Setter;
-import lombok.ToString;
-
-@Getter
-@Setter
-@ToString
-public class ZeppelinParameters extends AbstractParameters {
-
- /**
- * parameters for zeppelin client API
- * @see <a
href="https://zeppelin.apache.org/docs/0.9.0/usage/zeppelin_sdk/client_api.html";>Zeppelin_Client_API_Examples</a>
- */
- private String noteId;
- private String paragraphId;
- private String restEndpoint;
- private String productionNoteDirectory;
- private String parameters;
-
- @Override
- public boolean checkParameters() {
- return StringUtils.isNotEmpty(this.noteId) &&
StringUtils.isNotEmpty(this.restEndpoint);
- }
-
- @Override
- public List<ResourceInfo> getResourceFilesList() {
- return Collections.emptyList();
- }
-
-}
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.zeppelin;
+
+import org.apache.dolphinscheduler.plugin.task.api.model.ResourceInfo;
+import
org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.Collections;
+import java.util.List;
+
+import lombok.Getter;
+import lombok.Setter;
+import lombok.ToString;
+
+@Getter
+@Setter
+@ToString
+public class ZeppelinParameters extends AbstractParameters {
+
+ /**
+ * parameters for zeppelin client API
+ * @see <a
href="https://zeppelin.apache.org/docs/0.9.0/usage/zeppelin_sdk/client_api.html";>Zeppelin_Client_API_Examples</a>
+ */
+ private String noteId;
+ private String paragraphId;
+ private String restEndpoint;
+ private String productionNoteDirectory;
+ private String parameters;
+ private String userName;
Review Comment:
```suggestion
private String username;
```
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -668,6 +668,10 @@ export default {
zeppelin_parameters_tips: '请输入zeppelin dynamic form参数',
zeppelin_rest_endpoint: 'zeppelinRestEndpoint',
zeppelin_rest_endpoint_tips: '请输入zeppelin server的rest endpoint',
+ zeppelin_user_name: 'zeppelinUserName',
+ zeppelin_user_name_tips: '请输入zeppelin server的登陆用户名',
+ zeppelin_pass_word: 'zeppelinPassWord',
Review Comment:
```suggestion
zeppelin_password: 'zeppelinPassword',
```
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinParameters.java:
##########
@@ -1,57 +1,59 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.dolphinscheduler.plugin.task.zeppelin;
-
-import org.apache.dolphinscheduler.plugin.task.api.model.ResourceInfo;
-import
org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters;
-
-import org.apache.commons.lang3.StringUtils;
-
-import java.util.Collections;
-import java.util.List;
-
-import lombok.Getter;
-import lombok.Setter;
-import lombok.ToString;
-
-@Getter
-@Setter
-@ToString
-public class ZeppelinParameters extends AbstractParameters {
-
- /**
- * parameters for zeppelin client API
- * @see <a
href="https://zeppelin.apache.org/docs/0.9.0/usage/zeppelin_sdk/client_api.html";>Zeppelin_Client_API_Examples</a>
- */
- private String noteId;
- private String paragraphId;
- private String restEndpoint;
- private String productionNoteDirectory;
- private String parameters;
-
- @Override
- public boolean checkParameters() {
- return StringUtils.isNotEmpty(this.noteId) &&
StringUtils.isNotEmpty(this.restEndpoint);
- }
-
- @Override
- public List<ResourceInfo> getResourceFilesList() {
- return Collections.emptyList();
- }
-
-}
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.zeppelin;
+
+import org.apache.dolphinscheduler.plugin.task.api.model.ResourceInfo;
+import
org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.Collections;
+import java.util.List;
+
+import lombok.Getter;
+import lombok.Setter;
+import lombok.ToString;
+
+@Getter
+@Setter
+@ToString
+public class ZeppelinParameters extends AbstractParameters {
+
+ /**
+ * parameters for zeppelin client API
+ * @see <a
href="https://zeppelin.apache.org/docs/0.9.0/usage/zeppelin_sdk/client_api.html";>Zeppelin_Client_API_Examples</a>
+ */
+ private String noteId;
+ private String paragraphId;
+ private String restEndpoint;
+ private String productionNoteDirectory;
+ private String parameters;
+ private String userName;
+ private String passWord;
Review Comment:
```suggestion
private String password;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
