kingbabingge commented on code in PR #13811:
URL:
https://github.com/apache/dolphinscheduler/pull/13811#discussion_r1171979819
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-hdfs/src/main/java/org/apache/dolphinscheduler/plugin/storage/hdfs/HdfsStorageOperator.java:
##########
@@ -182,7 +182,7 @@ public Configuration getConfiguration() {
* @return DefaultFS
*/
public String getDefaultFS() {
- String defaultFS = getConfiguration().get(Constants.FS_DEFAULT_FS);
+ String defaultFS = getConfiguration().get(Constants.HDFS_DEFAULT_FS);
Review Comment:
@SbloodyS @Radeity
I thank maybe it can be changed to.
1. first get config from `resource.hdfs.fs.defaultFS`
2. if empty then get from ` core-site.xml/hdfs-site.xml `
A : If user not set the config , it means use `core-site.xml/hdfs-site.xml`
,it works.
B: They can reset the config by `resource.hdfs.fs.defaultFS` .
Both `resource.hdfs.fs.defaultFS` and ` core-site.xml/hdfs-site.xml ` canbe
used normally.
What do you think? ?
```java
public String getDefaultFS() {
// 1 . first get config from resource.hdfs.fs.defaultFS
String defaultFS = hdfsProperties.getDefaultFS();
// 2. second . if empty then get from core-site.xml
if (StringUtils.isBlank(defaultFS)) {
defaultFS =getConfiguration().get(Constants.HDFS_DEFAULT_FS);
}
return defaultFS;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
