Radeity commented on PR #13930: URL: https://github.com/apache/dolphinscheduler/pull/13930#issuecomment-1517303386
> E.g., `"'$SHELL'"` would become `'''$SHELL'''` in the previous discussion Yes, of course it will... If user defines commands in yaml (which is a more common way than json) before: `command: ["echo", "'$SHELL'"]` when they don't use DS. Now, they use DS, directly copy commands string, we can make sure that submit job with same commands like before, cuz we don't change any parse logic. So i think there's no need to tell user how to write command array, either, users should check k8s doc or yaml doc. Also, like we discuss about, quote has different usage in user commands, there's no generous example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
