zhongjiajie commented on code in PR #13866: URL: https://github.com/apache/dolphinscheduler/pull/13866#discussion_r1175029514
########## dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-databend/pom.xml: ########## @@ -0,0 +1,72 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.dolphinscheduler</groupId> + <artifactId>dolphinscheduler-datasource-plugin</artifactId> + <version>dev-SNAPSHOT</version> + </parent> + + <artifactId>dolphinscheduler-datasource-databend</artifactId> + <packaging>jar</packaging> + <name>${project.artifactId}</name> + + <dependencies> + <dependency> + <groupId>org.apache.dolphinscheduler</groupId> + <artifactId>dolphinscheduler-spi</artifactId> + </dependency> + + <dependency> + <groupId>org.apache.dolphinscheduler</groupId> + <artifactId>dolphinscheduler-datasource-api</artifactId> + <version>${project.version}</version> + </dependency> + + <dependency> + <groupId>com.databend</groupId> + <artifactId>databend-jdbc</artifactId> + <version>0.0.7</version> Review Comment: version should maintain in the bot module ```suggestion ``` ########## docs/docs/en/guide/datasource/databend.md: ########## @@ -0,0 +1,21 @@ +# Databend + + + +## Datasource Parameters + +| **Datasource** | **Description** | +|-------------------------|-------------------------------------------------------------| +| Datasource | Select DATABEND. | +| Datasource Name | Enter the name of the datasource. | +| Description | Enter a description of the datasource. | +| IP/Host Name | Enter the DATABEND service IP. | +| Port | Enter the DATABEND service port. | +| Username | Set the username for DATABEND connection. | +| Password | Set the password for DATABEND connection. | +| Database Name | Enter the database name of the DATABEND connection. | +| jdbc connect parameters | Parameter settings for DATABEND connection, in JSON format. | + +## Native Supported + +Yes, could use this datasource by default. Review Comment: Chinese and English version is different? ########## docs/docs/en/guide/datasource/databend.md: ########## @@ -0,0 +1,21 @@ +# Databend + + + +## Datasource Parameters + +| **Datasource** | **Description** | +|-------------------------|-------------------------------------------------------------| +| Datasource | Select DATABEND. | +| Datasource Name | Enter the name of the datasource. | +| Description | Enter a description of the datasource. | +| IP/Host Name | Enter the DATABEND service IP. | +| Port | Enter the DATABEND service port. | +| Username | Set the username for DATABEND connection. | +| Password | Set the password for DATABEND connection. | +| Database Name | Enter the database name of the DATABEND connection. | +| jdbc connect parameters | Parameter settings for DATABEND connection, in JSON format. | + +## Native Supported + +Yes, could use this datasource by default. Review Comment: should also add new docs in https://github.com/apache/dolphinscheduler/blob/c0126b7f30ff335aa1cfd62508b041084fb090d5/docs/configs/docsdev.js#L1011-L1014 and https://github.com/apache/dolphinscheduler/blob/c0126b7f30ff335aa1cfd62508b041084fb090d5/docs/configs/docsdev.js#L330-L333 ########## dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-datax.ts: ########## @@ -14,288 +14,289 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { ref, onMounted, watch } from 'vue' -import { useI18n } from 'vue-i18n' -import { useCustomParams, useDatasource, useResources } from '.' -import type { IJsonItem } from '../types' +import {ref, onMounted, watch} from 'vue' +import {useI18n} from 'vue-i18n' +import {useCustomParams, useDatasource, useResources} from '.' +import type {IJsonItem} from '../types' export function useDataX(model: { [field: string]: any }): IJsonItem[] { - const { t } = useI18n() - const jobSpeedByteOptions: any[] = [ - { - label: `0(${t('project.node.unlimited')})`, - value: 0 - }, - { - label: '1KB', - value: 1024 - }, - { - label: '10KB', - value: 10240 - }, - { - label: '50KB', - value: 51200 - }, - { - label: '100KB', - value: 102400 - }, - { - label: '512KB', - value: 524288 - } - ] - const jobSpeedRecordOptions: any[] = [ - { - label: `0(${t('project.node.unlimited')})`, - value: 0 - }, - { - label: '500', - value: 500 - }, - { - label: '1000', - value: 1000 - }, - { - label: '1500', - value: 1500 - }, - { - label: '2000', - value: 2000 - }, - { - label: '2500', - value: 2500 - }, - { - label: '3000', - value: 3000 - } - ] - const memoryLimitOptions = [ - { - label: '1G', - value: 1 - }, - { - label: '2G', - value: 2 - }, - { - label: '3G', - value: 3 - }, - { - label: '4G', - value: 4 - } - ] + const {t} = useI18n() Review Comment: it seem you change the file format, does it in need or modify by accident? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
