ruanwenjun commented on code in PR #13948:
URL:
https://github.com/apache/dolphinscheduler/pull/13948#discussion_r1176676224
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/utils/DagHelper.java:
##########
@@ -423,7 +423,7 @@ private static List<String> skipTaskNode4Switch(TaskNode
taskNode, Map<String, T
if (CollectionUtils.isEmpty(switchTaskList)) {
switchTaskList = new ArrayList<>();
}
- conditionResultVoList.remove(resultConditionLocation);
+ // conditionResultVoList.remove(resultConditionLocation);
Review Comment:
Because I find we will remove the location here and this will cause the
default branch cannot reach.
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/utils/DagHelper.java:
##########
@@ -423,7 +423,7 @@ private static List<String> skipTaskNode4Switch(TaskNode
taskNode, Map<String, T
if (CollectionUtils.isEmpty(switchTaskList)) {
switchTaskList = new ArrayList<>();
}
- conditionResultVoList.remove(resultConditionLocation);
+ // conditionResultVoList.remove(resultConditionLocation);
Review Comment:
Because I find we will remove the location here and this will cause the
condition default branch cannot reach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
