rickchengx commented on PR #14084:
URL: 
https://github.com/apache/dolphinscheduler/pull/14084#issuecomment-1547274193

   > > Hi, @rickchengx , delete resource after download it seems weird, can we 
remove parameter `deleteSource` in `download` method, WDYT?
   > 
   > good catch, download should be remove, and please add some desc in 
https://github.com/apache/dolphinscheduler/blob/d46e4659d917e1994bc9045c57fe3b865a308352/docs/docs/en/guide/upgrade/incompatible.md
 due to we make an incompatible change
   > 
   > But the copy method should be keep IMO
   
   Agree, I'll add this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to