zhongjiajie commented on PR #14131: URL: https://github.com/apache/dolphinscheduler/pull/14131#issuecomment-1552308225
> @zhongjiajie Yes, you're right. Seatunnel has changed a lot... > I've read your code and I think it will works well like you said, but I don't think that's a good solution to change EngineEnum to a common String property. Maybe we can have a better one. hi @kevinYuan2017 maybe you can fetch pr https://github.com/apache/dolphinscheduler/pull/14129 and run local, I think it is look like good IMO, due to we do not know wether seatunnel will change startup script in the further, And we just pass startup script name from frontend will be nice because we can change no code after seatunnel change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
