SbloodyS commented on code in PR #14089:
URL: 
https://github.com/apache/dolphinscheduler/pull/14089#discussion_r1198759002


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -879,4 +880,29 @@ public Result viewVariables(@Parameter(hidden = true) 
@RequestAttribute(value =
         return returnDataList(result);
     }
 
+    /**
+     * Batch release process definition by code states
+     *
+     * @param loginUser   Login user
+     * @param projectCode Project code
+     * @param codeStates  Process definition code states
+     * @return Result of the batch release operation
+     */
+    @Operation(summary = "batchReleaseProcessDefinitionByCodeStates", 
description = "BATCH_RELEASE_PROCESS_DEFINITION_BY_CODE_STATES_NOTES")
+    @Parameters({
+            @Parameter(name = "codeStates", description = "Process definition 
code states", required = true, schema = @Schema(implementation = String.class))
+    })
+    @PostMapping(value = "/batch-release")
+    @ResponseStatus(HttpStatus.OK)
+    @ApiException(BATCH_RELEASE_PROCESS_DEFINE_BY_CODE_STATES_ERROR)
+    @AccessLogAnnotation(ignoreRequestArgs = "loginUser")
+    public Result batchReleaseProcessDefinitionByCodeStates(
+                                                            @Parameter(hidden 
= true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
+                                                            @Parameter(name = 
"projectCode", description = "Project code", required = true) @PathVariable 
long projectCode,
+                                                            
@RequestParam("codeStates") String codeStates) {

Review Comment:
   Using json `codeStates` is not a good way. A good way is as mentioned here
    https://github.com/apache/dolphinscheduler/pull/14089/files#r1193518157



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to