hantmac opened a new issue, #14180:
URL: https://github.com/apache/dolphinscheduler/issues/14180

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   Because of the datasouce `databend` now does not support datax reader mode 
so the code here will return `null` when user select `databend` as datax reader:
   
   ```java
    public static String getReaderPluginName(DbType dbType) {
           switch (dbType) {
               case MYSQL:
                   return DATAX_READER_PLUGIN_MYSQL;
               case POSTGRESQL:
                   return DATAX_READER_PLUGIN_POSTGRESQL;
               case ORACLE:
                   return DATAX_READER_PLUGIN_ORACLE;
               case SQLSERVER:
                   return DATAX_READER_PLUGIN_SQLSERVER;
               case CLICKHOUSE:
                   return DATAX_READER_PLUGIN_CLICKHOUSE;
               case HIVE:
                   return DATAX_READER_PLUGIN_RDBMS;
               case PRESTO:
                   return DATAX_READER_PLUGIN_RDBMS;
               default:
                   return null;
           }
       }
   ```
   
   IMO, datax component of DS should separate the enumeration of the datasource 
and datatarget. And now it is enum together here:
   
   ```
   type IDataBase =
     | 'MYSQL'
     | 'POSTGRESQL'
     | 'HIVE'
     | 'SPARK'
     | 'CLICKHOUSE'
     | 'ORACLE'
     | 'SQLSERVER'
     | 'DB2'
     | 'PRESTO'
     | 'REDSHIFT'
     | 'ATHENA'
     | 'TRINO'
     | 'AZURESQL'
     | 'STARROCKS'
     | 'DAMENG'
     | 'OCEANBASE'
     | 'SSH'
     | 'DATABEND'
     | 'SNOWFLAKE'
   ```
   
   ### What you expected to happen
   
   The datax reader show available reader plugin instead of return `null`
   
   ### How to reproduce
   
   In DS UI using datax reader.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to