morningman commented on a change in pull request #1828: Seek block when starts
a ScanKey
URL: https://github.com/apache/incubator-doris/pull/1828#discussion_r325990989
##########
File path: be/src/olap/rowset/segment_reader.cpp
##########
@@ -832,7 +841,7 @@ OLAPStatus SegmentReader::_create_reader(size_t*
buffer_size) {
OLAPStatus SegmentReader::_seek_to_block_directly(
int64_t block_id, const std::vector<uint32_t>& cids) {
- if (!config::block_seek_position && _at_block_start && block_id ==
_current_block_id) {
+ if (!_seek_block && block_id == _current_block_id) {
Review comment:
Can we remove the config `config::block_seek_position`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
