wangbo commented on a change in pull request #1816: v2 segment support string
encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r326853869
##########
File path: be/src/olap/rowset/segment_v2/column_reader.cpp
##########
@@ -166,6 +167,24 @@ void ColumnReader::get_row_ranges_by_zone_map(CondColumn*
cond_column, RowRanges
_calculate_row_ranges(page_indexes, row_ranges);
}
+Status ColumnReader::get_dict_page_decoder(BinaryDictPageDecoder*
binaryDictPageDecoder) {
Review comment:
return status here can make FileColumnIterator returns error when read_page
failed or dict_page_decoder-> init failed;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
