morningman commented on a change in pull request #1679: Add fixed partitions
URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r327048553
##########
File path: fe/src/main/java/org/apache/doris/catalog/PartitionKey.java
##########
@@ -120,11 +120,34 @@ public boolean isMinValue() {
public boolean isMaxValue() {
for (LiteralExpr literalExpr : keys) {
- if (literalExpr != MaxLiteral.MAX_VALUE) {
- return false;
+ if (literalExpr == MaxLiteral.MAX_VALUE) {
+ return true;
Review comment:
You need to modify this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
