imay commented on a change in pull request #1869: Fix bug that backup may
create an empty file on remote storage.
URL: https://github.com/apache/incubator-doris/pull/1869#discussion_r328889481
##########
File path: be/src/runtime/snapshot_loader.cpp
##########
@@ -222,6 +222,13 @@ Status SnapshotLoader::upload(
read_offset += read_len;
left_len -= read_len;
}
+
+ // close manually, because we need to check its close status
+ broker_writer->close();
Review comment:
Better to return status than to check is_closed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
