imay commented on a change in pull request #1899: Use mem_pool replace arena
first step
URL: https://github.com/apache/incubator-doris/pull/1899#discussion_r329045025
##########
File path: be/src/olap/memtable.h
##########
@@ -57,11 +57,12 @@ class MemTable {
};
RowCursorComparator _row_comparator;
- Arena _arena;
+ std::unique_ptr<MemTracker> _tracker;
+ std::unique_ptr<MemPool> _mem_pool;
ObjectPool _agg_object_pool;
typedef SkipList<char*, RowCursorComparator> Table;
- char* _tuple_buf;
+ u_int8_t* _tuple_buf;
Review comment:
```suggestion
uint8_t* _tuple_buf;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
