kangkaisen commented on a change in pull request #1905: Fix es_scan_reader_test
in debug mode
URL: https://github.com/apache/incubator-doris/pull/1905#discussion_r329053577
##########
File path: be/src/exec/es/es_scan_reader.cpp
##########
@@ -104,9 +104,6 @@ Status ESScanReader::get_next(bool* scan_eos,
std::unique_ptr<ScrollParser>& scr
LOG(WARNING) << "request scroll search failure["
<< "http status" << status
<< ", response: " << (response.empty() ? "empty
response" : response);
- if (status == 404) {
Review comment:
It's unreachable
```
if (status == 404) {
LOG(WARNING) << "request scroll search failure 404["
<< ", response: " << (response.empty() ? "empty
response" : response);
return Status::InternalError("No search context found for " +
_scroll_id);
}
if (status != 200) {
LOG(WARNING) << "request scroll search failure["
<< "http status" << status
<< ", response: " << (response.empty() ? "empty
response" : response);
if (status == 404) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
