imay commented on a change in pull request #1930: Replace std::regex with RE2 URL: https://github.com/apache/incubator-doris/pull/1930#discussion_r333377465
########## File path: be/test/olap/tablet_mgr_test.cpp ########## @@ -209,6 +209,21 @@ TEST_F(TabletMgrTest, DropTablet) { ASSERT_TRUE(!dir_exist); } +TEST_F(TabletMgrTest, GetRowsetId) { + std::string path = _engine_data_path + "/data/0/15007/368169781/020000000000000100000000000000020000000000000003_0_0.dat"; + TTabletId tid; + TSchemaHash schema_hash; + ASSERT_TRUE(_tablet_mgr.get_tablet_id_and_schema_hash_from_path(path, &tid, &schema_hash)); + ASSERT_EQ(15007, tid); + ASSERT_EQ(368169781, schema_hash); Review comment: OK ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org