imay commented on a change in pull request #1931: Support segment zone map
URL: https://github.com/apache/incubator-doris/pull/1931#discussion_r333497324
##########
File path: be/src/olap/rowset/segment_v2/column_zone_map.cpp
##########
@@ -73,15 +91,22 @@ Status ColumnZoneMapBuilder::flush() {
RETURN_IF_ERROR(_page_builder->add((const uint8_t *)&data, &num));
// reset the variables
// we should allocate max varchar length and set to max for min value
- _reset_zone_map();
+ _reset_page_zone_map();
return Status::OK();
}
-void ColumnZoneMapBuilder::_reset_zone_map() {
- _field->set_to_max(_zone_map.min_value);
- _field->set_to_min(_zone_map.max_value);
- _zone_map.has_null = false;
- _zone_map.has_not_null = false;
+void ColumnZoneMapBuilder::_reset_zone_map(ZoneMap& zone_map) {
+ _field->set_to_max(zone_map.min_value);
+ _field->set_to_min(zone_map.max_value);
+ zone_map.has_null = false;
+ zone_map.has_not_null = false;
+}
+
+void ColumnZoneMapBuilder::_fill_zone_map_to_pb(ZoneMap* const from,
ZoneMapPB* const to) {
Review comment:
```suggestion
void ColumnZoneMapBuilder::_fill_zone_map_to_pb(const ZoneMap& from,
ZoneMapPB* const to) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
