yiguolei commented on a change in pull request #1950: Refactor txn manager 
methods
URL: https://github.com/apache/incubator-doris/pull/1950#discussion_r333861059
 
 

 ##########
 File path: be/src/olap/txn_manager.cpp
 ##########
 @@ -76,6 +76,33 @@ TxnManager::TxnManager() {
     }
 }
 
+OLAPStatus TxnManager::prepare_txn(TPartitionId partition_id, const 
TabletSharedPtr& tablet, TTransactionId transaction_id, 
 
 Review comment:
   1. It is very difficult to create tablet object during unit test and some 
times they are useful for example during load.
   2. In the past, partition id not in tablet. so that I keep partition id as a 
parameter.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to