yiguolei commented on a change in pull request #1945: And multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1945#discussion_r333914019
########## File path: be/src/olap/task/engine_clone_task.cpp ########## @@ -811,26 +824,22 @@ OLAPStatus EngineCloneTask::_clone_full_data(TabletSharedPtr tablet, TabletMeta* << ", version='" << local_version.first<< "-" << local_version.second << ", version_hash=" << local_version_hash; } - } else { Review comment: delete_rs_meta_by_version is only used here. I think we could remove this method and just save the rs metas in another list that not exist in src. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org