morningman commented on a change in pull request #1954: Limit the memory usage of Loading process URL: https://github.com/apache/incubator-doris/pull/1954#discussion_r334216796
########## File path: be/src/runtime/load_channel.cpp ########## @@ -0,0 +1,163 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "runtime/load_channel.h" + +#include "runtime/mem_tracker.h" +#include "runtime/tablets_channel.h" +#include "olap/lru_cache.h" + +namespace doris { + +LoadChannel::LoadChannel(const UniqueId& load_id, int64_t mem_limit) + : _load_id(load_id) { + _lastest_success_channel = new_lru_cache(8); + _mem_tracker.reset(new MemTracker(mem_limit, _load_id.to_string())); + // _last_updated_time should be set before being inserted to + // _load_channels in load_channel_mgr, or it may be erased + // immediately by gc thread. + _last_updated_time = time(nullptr); +} + +LoadChannel::~LoadChannel() { + LOG(INFO) << "load channel mem peak usage: " << _mem_tracker->peak_consumption() + << ", info: " << _mem_tracker->debug_string() + << ", load id: " << _load_id; + delete _lastest_success_channel; + + std::lock_guard<std::mutex> l(_lock); +} + +Status LoadChannel::open(const PTabletWriterOpenRequest& params) { + int64_t index_id = params.index_id(); + std::shared_ptr<TabletsChannel> channel; + { + std::lock_guard<std::mutex> l(_lock); + auto it = _tablets_channels.find(index_id); + if (it != _tablets_channels.end()) { + channel = it->second; + } else { + // create a new tablets channel + TabletsChannelKey key(params.id(), index_id); + channel.reset(new TabletsChannel(key, _mem_tracker.get())); + _tablets_channels.insert({index_id, channel}); + } + } + + RETURN_IF_ERROR(channel->open(params)); + + if (!_opened) { + _opened = true; + } + _last_updated_time = time(nullptr); + return Status::OK(); +} + +static void dummy_deleter(const CacheKey& key, void* value) { +} + +Status LoadChannel::add_batch( + const PTabletWriterAddBatchRequest& request, + google::protobuf::RepeatedPtrField<PTabletInfo>* tablet_vec) { + + int64_t index_id = request.index_id(); + // 1. get tablets channel + std::shared_ptr<TabletsChannel> channel; + { + std::lock_guard<std::mutex> l(_lock); + auto it = _tablets_channels.find(index_id); + if (it == _tablets_channels.end()) { + auto handle = _lastest_success_channel->lookup(std::to_string(index_id)); + // success only when eos be true + if (handle != nullptr && request.has_eos() && request.eos()) { + _lastest_success_channel->release(handle); + return Status::OK(); + } + std::stringstream ss; + ss << "load channel " << _load_id << " add batch with unknown index id: " << index_id; + return Status::InternalError(ss.str()); + } + channel = it->second; + } + + // 2. add batch to tablets channel + if (request.has_row_batch()) { + RETURN_IF_ERROR(channel->add_batch(request)); + } + + // 3. check if mem consumption exceed limit + { + std::lock_guard<std::mutex> l(_lock); + if (_mem_tracker->limit_exceeded()) { + VLOG(1) << "mem consumption: " << _mem_tracker->consumption() << " exceed limit. load id: " << _load_id; + std::shared_ptr<TabletsChannel> channel; + if (_find_largest_max_consumption_tablets_channel(&channel)) { + channel->reduce_mem_usage(); + } else { + // should not happen, add log to observe + LOG(WARNING) << "failed to find suitable tablets channel when mem limit execeed: " << _load_id; + } + } + } + + // 4. handle eos + Status st; + if (request.has_eos() && request.eos()) { + bool finished = false; + RETURN_IF_ERROR(channel->close(request.sender_id(), &finished, request.partition_ids(), tablet_vec)); + if (finished) { + std::lock_guard<std::mutex> l(_lock); + _tablets_channels.erase(index_id); + auto handle = _lastest_success_channel->insert( + std::to_string(index_id), nullptr, 1, dummy_deleter); + _lastest_success_channel->release(handle); + } + } + _last_updated_time = time(nullptr); + return st; +} + +bool LoadChannel::_find_largest_max_consumption_tablets_channel(std::shared_ptr<TabletsChannel>* channel) { Review comment: It may happen but with low possibility. And even if we choose 50, it is not a big deal. I will eave it unchanged. If it becomes a real case, change it later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
