yiguolei commented on a change in pull request #1976: And multi-path in
RowsetGraph
URL: https://github.com/apache/incubator-doris/pull/1976#discussion_r334336995
##########
File path: be/src/olap/tablet.cpp
##########
@@ -283,35 +164,70 @@ OLAPStatus Tablet::add_rowset(RowsetSharedPtr rowset,
bool need_persist) {
LOG(FATAL) << "failed to save rowset to local meta store" <<
rowset->rowset_id();
}
}
+ RETURN_NOT_OK(save_meta());
++_newly_created_rowset_num;
return OLAP_SUCCESS;
}
-OLAPStatus Tablet::modify_rowsets(const vector<RowsetSharedPtr>& to_add,
- const vector<RowsetSharedPtr>& to_delete) {
+OLAPStatus Tablet::add_rowsets(const vector<RowsetSharedPtr>& to_add) {
+ WriteLock wrlock(&_meta_lock);
Review comment:
should check whether the rowset with same rowset_id or with same version
already exists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
