morningman commented on a change in pull request #1992: [Bug-fix][Broker-load]
Fix the bug of the label already exists when the txn has been finished
URL: https://github.com/apache/incubator-doris/pull/1992#discussion_r335258873
##########
File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java
##########
@@ -814,18 +808,15 @@ public void afterVisible(TransactionState txnState,
boolean txnOperated) {
if (!txnOperated) {
return;
}
- executeAfterVisible(txnState);
+ executeReplayTxnAttachment(txnState);
updateState(JobState.FINISHED);
}
- protected void executeAfterVisible(TransactionState txnState) {
- }
-
@Override
public void replayOnVisible(TransactionState txnState) {
writeLock();
try {
- executeReplayOnVisible(txnState);
+ executeReplayTxnAttachment(txnState);
Review comment:
I think the name `executeReplayTxnAttachment` should be changed.
Or calling a "replay" method in "non-replay" method is weird
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
