imay commented on a change in pull request #2034: Fix scan bytes in doris
metrics
URL: https://github.com/apache/incubator-doris/pull/2034#discussion_r337822882
##########
File path: be/src/exec/olap_scanner.cpp
##########
@@ -455,7 +455,6 @@ void OlapScanner::update_counter() {
COUNTER_UPDATE(_rows_pushed_cond_filtered_counter,
_num_rows_pushed_cond_filtered);
COUNTER_UPDATE(_parent->_io_timer, _reader->stats().io_ns);
- COUNTER_UPDATE(_parent->_read_compressed_counter,
_reader->stats().compressed_bytes_read);
Review comment:
You can't remove this. In some case, _update_realtime_counter is not called
and `_reader->stats().compressed_bytes_read` is not zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
